[PATCH 1 of 6] sortdict: have update() accept either dict or iterable of key/value pairs

Ryan McElroy rm at fb.com
Mon Mar 9 18:35:49 CDT 2015


On 3/9/2015 3:24 PM, Angel Ezquerra wrote:
>> >I agree with you in general, but Python dict accepts both. Our sortdict should
>> >be the same.
> I agree with Yuya. The sortdict class is basically mercurial's 2.4
> compatible OrderedDict. As a dict-like class it makes a lot of sense
> for its update method to acceot the same sort of inputs as a regular
> dict, that is dicts or an iterable of key, value pairs.

Y'all convinced me, I withdraw all objections.

~Ryan


More information about the Mercurial-devel mailing list