[PATCH 1 of 4 RFC] hook: have a generic hook for transaction opening

Pierre-Yves David pierre-yves.david at ens-lyon.org
Tue Mar 10 03:14:28 CDT 2015



On 03/10/2015 01:07 AM, Pierre-Yves David wrote:
> # HG changeset patch
> # User Pierre-Yves David <pierre-yves.david at fb.com>
> # Date 1418264389 28800
> #      Wed Dec 10 18:19:49 2014 -0800
> # Node ID 82dea52f27319896a8d33a0b805f439107a94845
> # Parent  4ef4e3c3c00693868ba428e21ac092e559e4fcea
> hook: have a generic hook for transaction opening

This is RFC because I'm unhappy with the current names, but they are 
going to be bikesheded anyway. So I would like to get the topic moving 
and code is a good way to get that.

The name in this series are:

- txnopen (can abort)
- txnclosing (can abort)
- txnclosed

The name that would fit existing hooks best will probably be:

- pretxnopen (can abort)
- pretxnclose (can abort)
- txnclose

However, I always struggle to find out which of the hook can actually 
abort a transaction. so I like the "closed" version that settle this down.

So current optimal idea is probably:

- pretxnopen
- pretxnclose
- txnclosed

But I've also to admit that "txn" is not the most sexy thing we have 
ever done.

Though?

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list