[PATCH 1 of 5] record: move header class from record to patch

[Laurent Charignon]

Hi,

I was thinking about doing this in a later steps, first moving the code
and then consolidating with what is in patch.py.
Would you rather do it the other way around?


On 3/10/15, 10:22 AM, "Jordi Gutiérrez Hermoso" <jordigh at octave.org> wrote:

>On Tue, 2015-03-10 at 10:12 -0700, Laurent Charignon wrote:
>> # HG changeset patch
>> # User Laurent Charignon <lcharignon at fb.com>
>> # Date 1425931490 25200
>> #      Mon Mar 09 13:04:50 2015 -0700
>> # Node ID 6f6b0d8c18fd84b70009fcc6f4a88b6a883116c6
>> # Parent  4e865115566e75f938cbff9dcf081da39008a161
>> record: move header class from record to patch
>
>I think that in order for this patch series to be useful, it requires
>more work than just moving code from one file to another.
>
>In particular,
>
>> -class header(object):
>> -    """patch header
>> -
>> -    XXX shouldn't we move this to mercurial/patch.py ?
>> -    """
>
>XXX didn't we just do precisely this?
>
>At least update the comments. :-)

I will, thanks!
>
>