[Bug 4564] New: SSH commands broken on Windows

[mercurial-bugs at selenic.com]

http://bz.selenic.com/show_bug.cgi?id=4564

          Priority: normal
            Bug ID: 4564
                CC: mercurial-devel at selenic.com
          Assignee: bugzilla at selenic.com
           Summary: SSH commands broken on Windows
          Severity: bug
    Classification: Unclassified
                OS: Windows
          Reporter: reg at freebsd.org
          Hardware: PC
            Status: UNCONFIRMED
           Version: stable branch
         Component: Mercurial
           Product: Mercurial

Hi,

Recently upgraded to TortoiseHg 3.3.2 from 3.2.0, and found that I could no
longer access my central repo, that is running on a Linux box.  This is a
little non-standard, using hg-ssh with domain accounts (that all have spaces in
the user name).  Some debugging shows that the difference is in the command
line.

Working version has:
running "C:\Program Files (x86)\PuTTY\PLink.exe" "Jeremy
Lea"@hg.ucprc.ucdavis.edu "hg -R CalME serve --stdio"  

Non-working version has:
running "C:\Program Files (x86)\PuTTY\PLink.exe" '"Jeremy
Lea"'@hg.ucprc.ucdavis.edu "hg -R CalME serve --stdio"

This results in an authentication failure on the Unix side because it sees a
user name with single quotes in the name, and thus fails.

I believe this might be a result of changeset 23671:e3f30068d2eb, which is in
the correct time frame.  The correct fix is likely for _serverquote to 1) not
assume the shell is sh, and 2) check if the string is already quoted.

-- 
You are receiving this mail because:
You are on the CC list for the bug.