[PATCH hglib] hglib: Move string literals in the test code to util.b() (issue4520)

Matt Mackall mpm at selenic.com
Tue Mar 10 17:19:53 CDT 2015


On Mon, 2015-03-09 at 18:26 -0400, Brett Cannon wrote:
> # HG changeset patch
> # User Brett Cannon <brett at python.org>
> # Date 1425939985 14400
> #      Mon Mar 09 18:26:25 2015 -0400
> # Node ID 4c0f97d377a0d193743f1b43481dadefc1880cd0
> # Parent  fe74d55995393f6a72abce49da8d43e5fe37cdcd
> hglib: Move string literals in the test code to util.b() (issue4520)

Various things spotted by our automated checks (check-code and
check-commit in the hg repo):

- please don't uppercase "Move" in summary above

> +        rev0, node0 = self.client.commit(b('first'), addremove=True,
> +                                         date=now.isoformat(' ').encode('latin-1'))

- this and a couple other lines are too long

> -        print rev0, node0
> +        print(rev0, node0)

- not portable
- and now that my eyes are drawn to it, not related to $SUMMARY

I've fixed these up, but you might want to acquaint yourself with these
scripts.

-- 
Mathematics is the supreme nostalgia of our time.




More information about the Mercurial-devel mailing list