[PATCH 3 of 5] lazymanifest: fail if path or hash strings cannot be created

Martin von Zweigbergk martinvonz at google.com
Wed Mar 11 18:14:25 CDT 2015


# HG changeset patch
# User Martin von Zweigbergk <martinvonz at google.com>
# Date 1426106134 25200
#      Wed Mar 11 13:35:34 2015 -0700
# Node ID 91e8436e566b285254d11aec6dc6694ae50ff6e8
# Parent  7daaf234ddc08ee8dd171a6c2d3347e0caf1632e
lazymanifest: fail if path or hash strings cannot be created

While generating (path, hash, flags), we fail if flags cannot be
created. We should also fail if path or hash cannot be created.

diff -r 7daaf234ddc0 -r 91e8436e566b mercurial/manifest.c
--- a/mercurial/manifest.c	Wed Mar 11 13:26:36 2015 -0700
+++ b/mercurial/manifest.c	Wed Mar 11 13:35:34 2015 -0700
@@ -243,7 +243,7 @@
 	consumed = pl + 41;
 	flags = PyString_FromStringAndSize(l->start + consumed,
 									   l->len - consumed - 1);
-	if (flags) {
+	if (path && hash && flags) {
 		return PyTuple_Pack(3, path, hash, flags);
 	} else {
 		Py_XDECREF(path);


More information about the Mercurial-devel mailing list