[PATCH 4 of 5 evolve-ext] strip: add the option for wrapping the strip command

Durham Goode durham at fb.com
Fri Mar 20 12:32:00 CDT 2015



On 3/20/15 6:34 AM, Jordi GutiƩrrez Hermoso wrote:
> On Thu, 2015-03-19 at 18:14 -0700, Durham Goode wrote:
>> # HG changeset patch
>> # User Durham Goode <durham at fb.com>
>> # Date 1426793511 25200
>> #      Thu Mar 19 12:31:51 2015 -0700
>> # Node ID e93100523ef10fae3fcee2bdeac0f676ed842ecd
>> # Parent  0a4343392b3358584bd16e7b7f15e9c2264c9c8b
>> strip: add the option for wrapping the strip command
>>
>> Adds an experimental option for wrapping the existing strip command and
>> replacing its functionality with prune. It currently doesn't handle the --keep
>> case, but an upcoming patch will address that.
> Ehhhh, I'm not sure I want this.
>
> Sometimes I really do want to strip, outright strip. It's ok, I'm a
> big boy, I know what I'm doing. If I enable both the strip extension
> and evolve, why would evolve decide that I don't want to strip,
> against my explicit wishes?
>
> I could see a case for Evolve aliasing strip to prune if the strip
> extension isn't loaded, but not for acting against my explicit wishes.
>
>
We're migrating our existing user's onto evolve and in their minds 
'strip' is how they make commits go away.  They don't care if they're 
actually stripped, or just hidden, or sent to the moon.  So from a user 
experience stand point, the first step of deploying evolve is doing it 
in a way that changes as little of the UI as possible, then we'll 
introduce the new concepts piece by piece.

The functionality I added here is behind a config, so it won't affect 
existing evolve users.  It also adds '--bundle' to the strip command so 
you can tell it 'yes, i really want these commits deleted and put in a 
bundle'.


More information about the Mercurial-devel mailing list