[PATCH] largefiles: don't create chain of __contains__ calls

Martin von Zweigbergk martinvonz at google.com
Mon Mar 23 23:14:42 CDT 2015


On Mon, Mar 23, 2015 at 9:07 PM Matt Harbison <mharbison72 at gmail.com> wrote:

> On Mon, 23 Mar 2015 19:53:56 -0400, Martin von Zweigbergk
> <martinvonz at google.com> wrote:
>
> > On Wed, Mar 11, 2015 at 9:49 PM Martin von Zweigbergk
> > <martinvonz at google.com>
> > wrote:
> >
> >> +                        class lfilesmanifest(man1.__class):
> >>
> >
> > Drew (drgott) pointed out to me that it's spelled "__class__", not
> > "__class", so it looks like this patch of the other patch will need to be
> > patched itself :-( And there is no test coverage (clearly). I'll try to
> > add
> > a test if it's not too much work.
>
> Well, adding manifest command support turns out to be not so easy.  I
> think I'm running into issues with the repo filtering, and hacking around
> that, it wants to print the standins instead of the largefiles because it
> is iterating over context.  I've got something that works, but I need to
> run all of the tests, and think about unintended consequences on the off
> chance the tests run successfully.
>
> I'll put this on my list of things to figure out.  Thanks for pointing
> this out.


Thank you! I have no personal interest in largefiles, so I'm very happy if
someone who does deals with it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150324/44e52330/attachment.html>


More information about the Mercurial-devel mailing list