[PATCH 4 of 4 PoC issue4497] fileset: add wdir(set) to evaluate set in working directory (issue4497)

Yuya Nishihara yuya at tcha.org
Wed Mar 25 06:39:20 CDT 2015


On Wed, 25 Mar 2015 04:31:46 +0000, Martin von Zweigbergk wrote:
> On Tue, Mar 24, 2015 at 10:36 AM Matt Mackall <mpm at selenic.com> wrote:
> > On Wed, 2015-03-25 at 01:36 +0900, Yuya Nishihara wrote:
> > > # HG changeset patch
> > > # User Yuya Nishihara <yuya at tcha.org>
> > > # Date 1422098310 -32400
> > > #      Sat Jan 24 20:18:30 2015 +0900
> > > # Node ID 17865e7c47fda81763799c9a143b4452b874225f
> > > # Parent  9b86951b17b05684797489000c1e2df904f2edcc
> > > fileset: add wdir(set) to evaluate set in working directory (issue4497)
> > >
> > > "wdir()" can be used to avoid the ambiguity caused by evaluating a
> > fileset
> > > in both workingctx and target changectx.
> > >
> > >   $ hg revert 'set:wdir(added())'
> >
> > This looks powerful, but for this particular case, I think it's
> > disappointing that it's needed... because revert is one of the basic
> > uses I had in mind for filesets.
> >
> 
> And what a coincidence (I really didn't see this series until now) that I
> sent a fix for the same issue less than 2 hours later! Yuya, please see
> http://thread.gmane.org/gmane.comp.version-control.mercurial.devel/77615 in
> case you haven't already.

Yes, it looks nice.

> > Also, I think we should have a story for how to evaluate a set against
> > other revs than the working dir.

I'll revisit this later. I have draft patch for rev(set, revspec), but it
stopped because I couldn't figure out how it should handle multiple revisions.

Regards,


More information about the Mercurial-devel mailing list