[PATCH] revset: add hook after tree parsing

[Matt Mackall]

On Mon, 2015-03-30 at 22:31 +0000, Laurent Charignon wrote:
> 
> On 3/30/15, 3:28 PM, "Matt Mackall" <mpm at selenic.com> wrote:
> 
> >On Mon, 2015-03-30 at 13:08 -0700, Laurent Charignon wrote:
> >> # HG changeset patch
> >> # User Laurent Charignon <lcharignon at fb.com>
> >> # Date 1427232295 25200
> >> #      Tue Mar 24 14:24:55 2015 -0700
> >> # Node ID 3ca44121d0afad1aee19675e45ae78d4bbef3cf1
> >> # Parent  5b85a5bc5bbb9d8365953609d98e4dce7110e9b0
> >> revset: add hook after tree parsing
> >> 
> >> This will be useful to execute actions after the tree is parsed and
> >>before the
> >> revset returns a match. It can be used to enable direct hash access of
> >>revs
> >> that are hidden.
> >
> >This is not very clear. Apparently "enable direct hash access of revs
> >that are hidden" means "a user can do hg log -r <hiddenhash> without the
> >--hidden flag", amirite?
> Correct
> > 
> >
> >And I guess you'll do this by walking the parse tree and finding nodes
> >of the form ('symbol', 'abcd') and unhiding them before evaluating the
> >revset, right?
> Correct
> > This would be very hard for anyone to guess who wasn't
> >already vaguely aware of what you were working on.
> Understood, I can resubmit a patch with more context as you detailed here
> in this email.

I decided to tweak it in flight, thanks.

> >What about revision numbers and other symbols?
> I was thinking of only filtering the symbols that are hashes and not use
> revision numbers for direct access.
> What do you think of that?

Not sure, probably needs discussion.

-- 
Mathematics is the supreme nostalgia of our time.