[PATCH 2 of 2] tags: detect and repair corrupt tags portion of tags cache

[Gregory Szorc]

On Tue, Mar 31, 2015 at 6:29 AM, Matt Mackall <mpm at selenic.com> wrote:

> On Sun, 2015-03-29 at 17:10 -0700, Gregory Szorc wrote:
> > # HG changeset patch
> > # User Gregory Szorc <gregory.szorc at gmail.com>
> > # Date 1427672229 25200
> > #      Sun Mar 29 16:37:09 2015 -0700
> > # Node ID 2cb6b78cf818a082ee9a2518968f88c1819efed0
> > # Parent  2e21d3312350ce63785cda82526c951211e76bab
> > tags: detect and repair corrupt tags portion of tags cache
> >
> > As part of developing a tags cache patch, I inadvertently introduced
> > malformed tags entries in a tags cache file. I was surprised to learn
> > that Mercurial would let this malformed data linger and would print
> > warnings about it until the tags cache was updated.
> >
> > This patch changes the behavior so in invalid tags cache is
> > proactively repaired. This makes the end-user experience better, as it
> > prevents Mercurial from getting in a possibly endless loop of warning
> > about a malformed tags cache.
>
> Seems sensible, but see my previous note about how we should be silent
> when doing this.
>

I was going to say that there is precedence for this and I was just
following precedent. But I see you've just committed the removal of the
precedent. I'll update this patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150331/70232b6e/attachment.html>