[PATCH RESEND] keyword: use wvfs.rmtree to remove kwdemo directory

Christian Ebert blacktrash at gmx.net
Sat May 2 21:08:42 CDT 2015


* Christian Ebert on Sunday, May 03, 2015 at 02:24:59 +0100
> * Matt Mackall on Saturday, May 02, 2015 at 16:48:31 -0500
>> On Sat, 2015-05-02 at 08:34 +0100, Christian Ebert wrote:
>>> * Pierre-Yves David on Friday, May 01, 2015 at 16:56:28 -0700
>>>> On 05/01/2015 04:21 PM, Christian Ebert wrote:
>>>>> +    repo.wvfs.rmtree()
>>>> 
>>>> rmtree with no argument?
>>> 
>>> Yes, the entire self repo/tmpdir, like in subrepo.py.
>>> 
>>> At least that what happens, and it should.
>> 
>> That's quite a scary API, now that you've drawn it to my attention.
>> Makes it a little too easy to accidentally delete repositories. We
>> probably shouldn't have a default arg there.. and we might even consider
>> not accepting empty strings.
> 
> I can pass the temp dir as argument explicitly. That works as
> well in this case. You want me to resend again like that?

I suggest

repo.wvfs.rmtree(repo.root)

which should make it obvious that this is intentional.


-- 
Auftreten Tarzan und Martha -
ich hatte Sankt Pauli untersch├Ątzt.

_MICHAEL WEBER: MARTHA_ --->> http://www.blacktrash.org/baustellen/#martha


More information about the Mercurial-devel mailing list