[PATCH 3 of 6] log: add a status template
raf at durin42.com
Tue May 5 10:26:50 CDT 2015
On Tue, May 5, 2015 at 11:26 AM, Jordi Gutiérrez Hermoso
<jordigh at octave.org> wrote:
> On Tue, 2015-05-05 at 10:40 -0400, Augie Fackler wrote:
>> On Sat, May 02, 2015 at 12:56:18AM -0400, Jordi Gutiérrez Hermoso wrote:
>> > # HG changeset patch
>> > # User Jordi Gutiérrez Hermoso <jordigh at octave.org>
>> > # Date 1430070569 14400
>> > # Sun Apr 26 13:49:29 2015 -0400
>> > # Node ID 824b9b5a5521bfdb5325fe3bb2498f8c3a5fbc94
>> > # Parent 384995922773c4c2e7086a1843afd91b94b259ef
>> > log: add a status template
>> I like this patch, but I'm slightly confused by the test output
>> changes down here. Are these changes expected? Can the changes to the
>> test construction be split out of the test of the new feature so it's
>> easier for me to figure out what's going on?
> My patch added a new commit and that commit also changed the output of
> a few other tests. I thought it was innocuous to let it be, and one
> extra commit might expose other codepaths in the future.
> Would you prefer I instead strip that extra commit before proceeding
> with the other tests?
I'm perfectly content to let the commit live on - can you add the new
commit in one patch and then the new functionality in a separate one?
That'll ease my life as a reviewer.
More information about the Mercurial-devel