[PATCH] commit: add --allow-empty flag

[Augie Fackler]

On Thu, May 07, 2015 at 07:51:21PM -0400, Jordi Gutiérrez Hermoso wrote:
> On Thu, 2015-05-07 at 15:10 -0700, Durham Goode wrote:
> > # HG changeset patch
> > # User Durham Goode <durham at fb.com>
> > # Date 1431034538 25200
> > #      Thu May 07 14:35:38 2015 -0700
> > # Node ID 9f90e53f8e810db2d6b0e4cf66433166c4d42934
> > # Parent  c5d4f9cc8da7bb2068457e96e4f74ff694514ced
> > commit: add --allow-empty flag

[snip]

> >
> > In general, allowing the user to create the DAG as they see fit seems useful,
> > and when I mentioned this in IRC more than one person piped up and said they
> > were already hacking around this limitation by using mq, import, and
> > commit-dummy-change-then-amend-the-content-away style solutions.
>
> I want to argue against this change because of the extra UI clutter,
> but I can't really justify it. It's just one more option and there are
> several situations in which yes, we really do want an empty
> placeholder commit. So against my natural impulses, I'm in favour of
> adding an option.

I feel the same way. I guess I'm +0 on this, especially since some
folks are (ab)using mq to make this kind of commit anyway.

We should probably spend a little time on rebase to make sure that it
doesn't elide empty changes when the source change is also empty.