[PATCH 1 of 2 V2] pathencode.c: for long paths, strip first dir, whether or not it's "data/"

Adrian Buehlmann adrian at cadifra.com
Fri May 8 12:08:17 CDT 2015


On 2015-05-08 16:37, Augie Fackler wrote:
> +1 - as long as at the end of this exercise the pure and c code do the
> same thing, I don't care much what that thing is.
> 

The thing is, that we introduced a whole new repository format in the
past, because of dire path length limitations on Windows. Now we seem to
have to debate about why a new subdirectory under 'store' has to be the
lengthy 'metadata' - in a directory, no user ever needs to cd into.

I don't really care that much about Mercurial anymore these days. But I
really fail to see why someone would want to waste that much path
length, making it needlessly harder again for Windows.

Also, in defense of existing C-code written by Bryan (which we had long
discussions about on this very list), choosing a name that is four
characters long, as I understand it, would appear to allow leaving the
existing C code as it is (which includes leaving it as fast as it
currently is).

Last but not least, C-code changes are always risky. May I just remind
of http://bz.selenic.com/show_bug.cgi?id=3958




More information about the Mercurial-devel mailing list