[PATCH] commit: add --allow-empty flag

[Pierre-Yves David]

On 05/07/2015 03:10 PM, Durham Goode wrote:
> # HG changeset patch
> # User Durham Goode <durham at fb.com>
> # Date 1431034538 25200
> #      Thu May 07 14:35:38 2015 -0700
> # Node ID 9f90e53f8e810db2d6b0e4cf66433166c4d42934
> # Parent  c5d4f9cc8da7bb2068457e96e4f74ff694514ced
> commit: add --allow-empty flag

I'm -1 on adding the new flag and +1 on the ability in core.

Given that apparently multiple users exists for that and that conversion 
from other VCS requires it, it makes sense to make it somewhat available.

However it is still far too much a corner case to be a first class 
citizen. Moreover, the most probable usage of that are automation who do 
not really care about the extra hurdle of going through something more 
complicated.
Commit is an important user facing command and its option tend to 
trickle down to a lot of other commands. In my opinion. This feature is 
not generic/useful for normal user enough to justify a dedicated flag.

I would go for a config option probably in the [ui] section.

As Augie mentioned, we also have to make sure rebase/graft/histedit/etc 
preserve them.


-- 
Pierre-Yves David