[PATCH] run-tests: implement Test._testMethodName

Pierre-Yves David pierre-yves.david at ens-lyon.org
Fri May 8 13:12:48 CDT 2015


# HG changeset patch
# User Pierre-Yves David <pierre-yves.david at fb.com>
# Date 1431065928 25200
#      Thu May 07 23:18:48 2015 -0700
# Node ID 3eccbad125c37db8395210ac714bbccf73c215b2
# Parent  17ba4ccd20b48511b3d06ab47fb1b2faf31410d7
run-tests: implement Test._testMethodName

This methods is needed internally by utilities like __repr__. I do not see any
harm in having it declared. Any actual attempt to use it to call a test would
crash, but at least random debug print in the test runner will no longer crash.

Another approach would have been to redefine the __repr__ function, but I think
it a good thing to have some respect for the base class API.

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -440,10 +440,15 @@ class Test(unittest.TestCase):
             self._refout = f.read().splitlines(True)
             f.close()
         else:
             self._refout = []
 
+    # needed to get base class __repr__ running
+    @property
+    def _testMethodName(self):
+        return self.name
+
     def __str__(self):
         return self.name
 
     def shortDescription(self):
         return self.name


More information about the Mercurial-devel mailing list