[PATCH 1 of 2] lazymanifest: avoid 'bail' label when used on success path

[Pierre-Yves David]

On 05/10/2015 12:57 PM, Matt Mackall wrote:
> On Fri, 2015-05-08 at 09:36 -0700, Martin von Zweigbergk wrote:
>> # HG changeset patch
>> # User Martin von Zweigbergk <martinvonz at google.com>
>> # Date 1428847959 25200
>> #      Sun Apr 12 07:12:39 2015 -0700
>> # Node ID e98a8adb3ec29849696e81996cc76a40e67c3905
>> # Parent  8179af513aebf96c4902ba3e5e3cf710d49501e4
>> lazymanifest: avoid 'bail' label when used on success path
>>
>> 3d485727e45e (lazymanifest: extract function for iterating to next
>> line, 2015-03-11) introduced a large memory leak because I stopped
>> running the 'bail' block in the successful case. Let's rename 'bail'
>> to 'done', since it has to run not only in the error case.
>
> Since the aforementioned change was before our 3.4 release, it's not
> clear why this shouldn't be on the stable branch? Do we have a big
> memory leak for normal 3.4 users?

As I understant it, the memory leak have been already fixed but the 
naming was still ambiguous. This changeset is just addressing the naming 
issue to prevent similar mistake in the future.

Martin, did I got that right?

-- 
Pierre-Yves David