[PATCH evolve-ext] bookmarks: update to use new bookmarks api via compatibility layer

Ryan McElroy rm at fb.com
Mon May 11 14:36:26 CDT 2015


On 5/10/2015 1:02 PM, Matt Mackall wrote:
> On Sat, 2015-05-09 at 18:59 -0700, Ryan McElroy wrote:
>> # HG changeset patch
>> # User Ryan McElroy <rmcelroy at fb.com>
>> # Date 1431030011 25200
>> #      Thu May 07 13:20:11 2015 -0700
>> # Branch stable
>> # Node ID 3a177ff325cc2d6fef34eaf35ace9e4e550deb86
>> # Parent  1218ad94a351b8294a4627a0ec9a27b68206c5b9
>> bookmarks: update to use new bookmarks api via compatibility layer
>>
>> Tested against 3.4 and latest hg + upcoming bookmarks patches
> I locally had to make 3 hacks to get "hg next" working for my usual
> review process: activate / deactivate / repo._activebookmark. I only see
> two of them here.
>

I can't find where activate is used inside of evolve -- are you sure 
that change was necessary?

searching through evolve's log -p for 'setcurrent' (as well as using 
histedit --all) was also unhelpful for me figuring out what that might 
have been necessary.

Several other extensions certainly need this -- I've added it to some of 
FB's extensions (like remotenames for example), any chance this is what 
you were seeing? (A subtle way to ask, "do you use remotenames?")



More information about the Mercurial-devel mailing list