[PATCH 1 of 2] phases: add set per phase in C phase computation

Matt Mackall mpm at selenic.com
Tue May 12 13:18:00 CDT 2015


On Mon, 2015-05-04 at 13:06 -0700, Laurent Charignon wrote:
> # HG changeset patch
> # User Laurent Charignon <lcharignon at fb.com>
> # Date 1427912237 25200
> #      Wed Apr 01 11:17:17 2015 -0700
> # Node ID 73bd80fd6a2f41805e81f981a6fd48c04a496300
> # Parent  e9edd53770fb77a9787a3e6592a3bf0a29c1bd80
> phases: add set per phase in C phase computation
> @@ -191,7 +191,6 @@
>                      revs[rev] = phase
>                  for rev in repo.changelog.descendants(roots):
>                      revs[rev] = phase
> -
>      def getphaserevs(self, repo):
>          if self._phaserevs is None:
>              try:

Oops

> @@ -199,7 +198,8 @@
>                                        'nativephaseskillswitch'):
>                      self._computephaserevspure(repo)
>                  else:
> -                    self._phaserevs = self._getphaserevsnative(repo)
> +                    res = self._getphaserevsnative(repo)
> +                    self._phaserevs, self._phasesets = res

You've changed the prototype of the function.. thus negating all the
effort to not require a recompile when updating across this revision.
If you must, you should change the name of the function so that older
Mercurial won't try to use it.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list