[PATCH 6 of 6] tests: check import cycles in hgext/**.py, too

[Augie Fackler]

> On May 13, 2015, at 20:19, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
> 
> 
> 
> On 05/13/2015 05:15 PM, Augie Fackler wrote:
>> 
>>> On May 13, 2015, at 20:12, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
>>> 
>>> 
>>> 
>>> On 05/13/2015 05:11 PM, Augie Fackler wrote:
>>>> On Wed, May 13, 2015 at 04:43:43PM -0700, Pierre-Yves David wrote:
>>>>> 
>>>>> 
>>>>> On 05/13/2015 09:53 AM, FUJIWARA Katsunori wrote:
>>>>>> # HG changeset patch
>>>>>> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
>>>>>> # Date 1431535750 -32400
>>>>>> #      Thu May 14 01:49:10 2015 +0900
>>>>>> # Node ID e4eba789328746bf2f4e2a0498c0afb08b80ae34
>>>>>> # Parent  28a977036067ea7bb0af50218edbee9abe82331a
>>>>>> tests: check import cycles in hgext/**.py, too
>>>>> 
>>>>> This series looks good to me and I've pushed it to the clowncopter.
>>>>> CCing Augie as I think he may have a stronger opinion than me.
>>>> 
>>>> Patches 1 and 6 are obviously correct, but I'm unclear on the
>>>> correctness of 3 and 4, and therefore am also unsure of the merits of
>>>> 2 and 5.
>>> 
>>> What kind of uncorrectness do you fear?
>> 
>> Basically, shadowing builtin module names in Python 3 is a dangerous proposition. Right now we have some places where the import-checker says we mix local imports with upstream packages, and we're actually (correctly) getting all local modules, but that breaks in Python 3 unless we move to explicit relative imports everywhere. I thought I responded to patch 3 with my concerns.
> 
> You reply to patch 3 was fairly vague.
> 
>> I'm tired from travel at this point, but am happy to talk more tomorrow about this series.
> 
> Do you want me to drop it from the clowncopter?

That would be my preference, yes.

> 
> -- 
> Pierre-Yves David