[PATCH 1 of 4 V2] checkcode: remove check for context manager

Laurent Charignon lcharignon at fb.com
Wed May 13 19:26:04 CDT 2015


# HG changeset patch
# User Laurent Charignon <lcharignon at fb.com>
# Date 1431563011 25200
#      Wed May 13 17:23:31 2015 -0700
# Node ID 92b5fa4e1be509cd7206e8f04c3dc3d1cefa58bf
# Parent  7c324f65e4efb3310f7664df3da94363bef76765
checkcode: remove check for context manager

Since we moved on from python 2.4 to python 2.6, we can get rid of this test.

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -247,7 +247,6 @@
 #    (r'^\s*print\s+', "avoid using print in core and extensions"),
     (r'[\x80-\xff]', "non-ASCII character literal"),
     (r'("\')\.format\(', "str.format() not available in Python 2.4"),
-    (r'^\s*with\s+', "with not available in Python 2.4"),
     (r'\.isdisjoint\(', "set.isdisjoint not available in Python 2.4"),
     (r'^\s*except.* as .*:', "except as not available in Python 2.4"),
     (r'^\s*os\.path\.relpath', "relpath not available in Python 2.4"),


More information about the Mercurial-devel mailing list