[PATCH against-clowncopter] run-tests: add a --profile option

Sean Farley sean at farley.io
Fri May 15 14:56:05 CDT 2015


Pierre-Yves David <pierre-yves.david at ens-lyon.org> writes:

> On 05/14/2015 10:40 AM, Augie Fackler wrote:
>> On Wed, May 13, 2015 at 9:00 PM, Pierre-Yves David
>> <pierre-yves.david at ens-lyon.org> wrote:
>>>
>>>
>>> On 05/13/2015 05:42 PM, Augie Fackler wrote:
>>>>
>>>> # HG changeset patch
>>>> # User Augie Fackler <augie at google.com>
>>>> # Date 1431541326 25200
>>>> #      Wed May 13 11:22:06 2015 -0700
>>>> # Node ID 21735d2bcefb10605708a1dc640a6cfa590c1361
>>>> # Parent  130c305f79910395cbfb73a442cc512605f78bc5
>>>> run-tests: add a --profile option
>>>>
>>>> While in the throes of a recent run-tests adventure, I found it useful
>>>> to have profiler output for the testrunner itself. Adding it was
>>>> simple enough and seems worth keeping around.
>>>
>>>
>>> Maybe? the amount of option in run-tests.py is already quite scary and one
>>> could hope that --profile would give --profile output for the tests
>>> themself.
>>
>> Maybe we should have a --profile-self and --profile-test flag then?
>>
>> I'm not clear what profiling a test would look like. We'd have to
>> implement that, which seems unlikely to happen?
>
> This does not seems so unlikely to me. gathering profile on each Python 
> invocation or on the test script performance would not be so hard and 
> provide useful information
>
> --profile-self seems fine with me.

What about --profile-runner? Seems more explicit than 'self' to me.


More information about the Mercurial-devel mailing list