[PATCH] util: kill Python 2.4 deque.remove hack

Martin von Zweigbergk martinvonz at google.com
Sat May 16 18:08:43 CDT 2015


On Sat, May 16, 2015 at 2:34 PM Adrian Buehlmann <adrian at cadifra.com> wrote:

> On 2015-05-16 23:08, Martin von Zweigbergk wrote:
> >
> >
> > On Sat, May 16, 2015 at 11:38 AM Augie Fackler <raf at durin42.com
> > <mailto:raf at durin42.com>> wrote:
> >
> >
> >     On May 16, 2015, at 2:33 PM, Martin von Zweigbergk
> >     <martinvonz at google.com <mailto:martinvonz at google.com>> wrote:
> >
> >     > I've pushed this to the clowncopter, thanks. Will send my
> >     follow-up patch once this patch is in Matt's repo.
> >
> >     If you want, I’d be happy to review the removal of the name forward
> >     series and then you could clowncopterize it.
> >
> >
> > Yes, please. Take a look at
> >
> https://bitbucket.org/martinvonz/hg/commits/0ca8410ea3455bcef5b9335ca6d9aa2de4adc2c9
> .
> > Thanks!
>
> Looks good enough to me. If the testsuite passes, just push that thing.
>

Pushed to the clowncopter. Thanks for reviewing.

What is it that makes it only "good enough"? Is the imports you are not
quite happy with?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150516/17cbe9d5/attachment.html>


More information about the Mercurial-devel mailing list