[PATCH 4 of 4 V3] tests: check import cycles in hgext/**.py, too

Augie Fackler raf at durin42.com
Mon May 18 15:28:15 CDT 2015


On Mon, May 18, 2015 at 03:12:05AM +0900, FUJIWARA Katsunori wrote:
> # HG changeset patch
> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> # Date 1431885188 -32400
> #      Mon May 18 02:53:08 2015 +0900
> # Node ID d014ac62d58dff93eb3321eda61aeca6f551e971
> # Parent  d5f67e3c14705947f5d3f192159da126d14ff407
> tests: check import cycles in hgext/**.py, too

These look good to me, so they'll end up in crew soon. Thanks!

>
> It is important to realize existing cycles in hgext/**.py.
>
> diff --git a/tests/test-module-imports.t b/tests/test-module-imports.t
> --- a/tests/test-module-imports.t
> +++ b/tests/test-module-imports.t
> @@ -20,7 +20,7 @@ here that we should still endeavor to fi
>  hidden by deduplication algorithm in the cycle detector, so fixing
>  these may expose other cycles.
>
> -  $ hg locate 'mercurial/**.py' | sed 's-\\-/-g' | python "$import_checker" -
> +  $ hg locate 'mercurial/**.py' 'hgext/**.py' | sed 's-\\-/-g' | python "$import_checker" -
>    mercurial/dispatch.py mixed imports
>       stdlib:    commands
>       relative:  error, extensions, fancyopts, hg, hook, util
> @@ -37,4 +37,5 @@ these may expose other cycles.
>       stdlib:    formatter
>       relative:  config, error, scmutil, util
>    Import cycle: mercurial.cmdutil -> mercurial.context -> mercurial.subrepo -> mercurial.cmdutil
> +  Import cycle: hgext.largefiles.basestore -> hgext.largefiles.localstore -> hgext.largefiles.basestore
>    Import cycle: mercurial.commands -> mercurial.commandserver -> mercurial.dispatch -> mercurial.commands
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list