[PATCH] util: kill Python 2.4 deque.remove hack

Adrian Buehlmann adrian at cadifra.com
Tue May 19 01:13:03 CDT 2015

On 2015-05-19 07:56, Pierre-Yves David wrote:
> On 05/16/2015 02:06 AM, Martin von Zweigbergk wrote:
>> Does a follow-up that replaces util.deque with collections.deque make
>> sense? I suppose the hack was the only reason for the alias...
> I feel we should be methodical about this. Dropping the check/util 
> implementation without actually cleaning the code base is a free ticket 
> to obscure technical debt.

I also feel you should be methodical about this. Separating the action
in two patches was actually a good thing.

BTW, the code is actually quite sprinkled with technical debt already.
Cleaning it up incrementally is better than not making any progress at all.

BTW 2, there may have actually been good reasons for keeping the deque
alias a bit. After all, it was public.

I'm perfectly ok with not sending such patches any more though, if you
don't want them.

More information about the Mercurial-devel mailing list