[PATCH] util: kill Python 2.4 deque.remove hack

Adrian Buehlmann adrian at cadifra.com
Tue May 19 02:14:08 CDT 2015

On 2015-05-17 01:08, Martin von Zweigbergk wrote:
> What is it that makes it only "good enough"? Is the imports you are not
> quite happy with?

No. I'm fine with the imports. You even seem to have been removing one
which is no longer needed after removing a use of the removed alias.

I think I wrote "good enough" because I'm not able to verify the patch
completely without redoing the work you did. This is one of the sort of
patches where you can't say it is obviously correct or not. If you've
run the testsuite, then it is ok. I didn't even run the testsuite
myself, because I think I can trust you having done that.

(BTW, we seem to spend an amazing amount of time on such minor issues.)

More information about the Mercurial-devel mailing list