[PATCH 5 of 5] sshpeer: run the ssh command unbuffered

Pierre-Yves David pierre-yves.david at ens-lyon.org
Fri May 22 12:08:40 CDT 2015



On 05/22/2015 11:37 AM, Matt Mackall wrote:
> On Wed, 2015-05-20 at 18:53 -0500, Pierre-Yves David wrote:
>> # HG changeset patch
>> # User Pierre-Yves David <pierre-yves.david at fb.com>
>> # Date 1432139498 18000
>> #      Wed May 20 11:31:38 2015 -0500
>> # Node ID 41cdf78c6c38b842b8dbed6c0d9e87144f8fedce
>> # Parent  f0f5363aafdce72c18936ab478480a47b230a941
>> sshpeer: run the ssh command unbuffered
>
> I'm going to wait on this one until we've researched whether it
> regresses OS X. I've queued the rest for default, thanks.

On my linux here is what local ssh operation give me with this series 
(on mercurial-devel repository evolve enabled)

1) current public tip
2) ssh unbuffered
3) full patch series for real time output

First number is the number of read call. The second one is the timing of 
the whole operation in second

clone
1) 72068 40s
2) 99064 41s
3) 98983 43s

pull 1000:
1) 3940 7.1s
2) 5447 7.1s
3) 5445 7.3s

push 1000:
1) 2026 9.0s
2) 2739 8.4s
3) 2748 8.3s

note:
- the push number are puzzling
- I think our lazy reading from the stderr pipe could be more efficient.




-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list