[PATCH 3 of 4] revlog: raise an exception earlier if an entry is too large

Adrian Buehlmann adrian at cadifra.com
Fri May 22 15:00:44 CDT 2015


On 2015-05-22 19:40, Jordi Gutiérrez Hermoso wrote:
> On Fri, 2015-05-22 at 12:05 -0500, Matt Mackall wrote:
>> On Thu, 2015-05-21 at 16:30 -0400, Jordi Gutiérrez Hermoso wrote:
>>> # HG changeset patch
>>> # User Jordi Gutiérrez Hermoso <jordigh at octave.org>
>>> # Date 1432239712 14400
>>> #      Thu May 21 16:21:52 2015 -0400
>>> # Node ID 94b79351d9569b65c3c111cbfe88a03112d617a9
>>> # Parent  88b99c48761cc7b982b84294aa679b63f5edf967
>>> revlog: raise an exception earlier if an entry is too large
>>
>> Issue number?
> 
> I considered the 4th patch in this series to address the issue, but I
> suppose this one does too. Is it ok to have two patches with the same
> issue number?

I'd say yes. Splitting of patches should not be dictated by issue
fixing. If it makes sense to have multiple patches by the usual rules,
do it.

Precedent: I've done that (two patches with the same issue number) in
e1002cf9fe54 and e98581d44f0b, fixing

    http://bz.selenic.com/show_bug.cgi?id=2513

This was in 2010 and "HG Bot" was able to handle it.


More information about the Mercurial-devel mailing list