[PATCH 2 of 2 V3] changelog: fix bug in heads computation

Laurent Charignon lcharignon at fb.com
Tue May 26 14:27:17 CDT 2015


Also, we certainly want to stop using both ints and Py_ssize_t for
revision numbers but use Py_ssize_t everywhere.
I will send a series of patches this week to move in that direction if
that's okay with you.

On 5/26/15, 12:12 PM, "Laurent Charignon" <lcharignon at fb.com> wrote:

>You are right, thanks for catching that Pierre-Yves, I will send a v4
>
>
>On 5/26/15, 11:55 AM, "Augie Fackler" <raf at durin42.com> wrote:
>
>>On Thu, May 21, 2015 at 6:59 PM, Laurent Charignon <lcharignon at fb.com>
>>wrote:
>>>  static PyObject *index_headrevs(indexObject *self, PyObject *args)
>>>  {
>>> -       Py_ssize_t i, len, addlen;
>>> +       int i, j, len;
>>
>>
>>In a wonderful catch by Pierre-yves, these variables don't want to become
>>int.
>>
>>Also, check-code says hi. I'm dropping patch 2 for now, but patch 1 is
>>pushed.
>
>_______________________________________________
>Mercurial-devel mailing list
>Mercurial-devel at selenic.com
>https://selenic.com/mailman/listinfo/mercurial-devel



More information about the Mercurial-devel mailing list