Properly initialize version string in python-hglib setup.py

[Peter Elmers]

If it were up to me, I'd fill out the version number directly and update it on each release by hand rather than tussle with pulling it out of the version control. Maybe I'm missing something; what is the motivation for the parsing that we do here? https://www.selenic.com/repo/python-hglib/file/ec935041d1ff/setup.py#l4




     On Thursday, May 28, 2015 5:38 AM, Yuya Nishihara <yuya at tcha.org> wrote:
   

 On Wed, 27 May 2015 14:33:28 -0400, Augie Fackler wrote:
> mpm, as an FYI here's an hglib patch that I'm just delegating to you.
> On Tue, May 26, 2015 at 10:56:29PM +0000, Peter Elmers wrote:
> > # HG changeset patch
> > # User Peter Elmers <peter.elmers at yahoo.com>
> > # Date 1432680605 25200
> > #      Tue May 26 15:50:05 2015 -0700
> > # Node ID 9afa1d6c9da357b3f61f7e4eb4b08390c4bc5fd1
> > # Parent  ec935041d1ff0fd2aa8cb666d79e6dcca398ddba
> > version: declare a default version in setup.py (issue3924)
> >
> > Leaving version as "unknown" breaks `pip freeze`, so we should default the
> > version to the current version and let it update itself if a more precise one
> > can be pulled from version control.
> >
> > diff -r ec935041d1ff -r 9afa1d6c9da3 setup.py
> > --- a/setup.py    Wed Apr 01 13:34:58 2015 -0500
> > +++ b/setup.py    Tue May 26 15:50:05 2015 -0700
> > @@ -2,7 +2,7 @@
> >  from distutils.core import setup
> >
> >  # query Mercurial for version number
> > -version = 'unknown'
> > +version = '1.6'

Perhaps we can parse PKG-INFO file just like we do for .hg_archival.txt.

https://www.python.org/dev/peps/pep-0314/


  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20150529/3b24a7a4/attachment.html>