[PATCH 2 of 2 STABLE] i18n: look translation of both "DEPRECATED" and "(DEPRECATED)" up

[FUJIWARA Katsunori]

At Tue, 3 Nov 2015 23:05:11 +0900,
Yuya Nishihara wrote:
> 
> On Tue, 03 Nov 2015 20:27:43 +0900, FUJIWARA Katsunori wrote:
> > Yes, message catalogue not containing 'msgid "(DEPRECATED)"' should be
> > out-of-date one.
> > 
> > But if we look up only 'msgid "(DEPRECATED)"' in *.po file, all
> > "(DEPRECATED)" related translations is treated as "inconsistently
> > translated (DEPRECATED)", even if it contain reasonable translation of
> > "DEPRECATED".
> > 
> > For example, *.po files categorized into (1-2) below cause such
> > meaningless warning.
> > 
> >                        msgID              msgSTR related to
> >              "DEPRECATED" "(DEPRECATED)"  (DEPRECATED)
> > 
> >   (0)
> >     fr.po        x           x               x
> > 
> >   (1-1)
> >     el.po        o           x               x
> >     zh_TW.po     o           x               x
> > 
> >   (1-2)
> >     da.po        o           x               o
> >     it.po        o           x               o
> >     ro.po        o           x               o
> >     zh_CN.po     o           x               o
> > 
> >   (2)
> >     de.po        o           o               o
> >     ru.po        o           o               o
> >     sv.po        o           o               o
> > 
> >   (3)
> >     ja.po        x           o               o
> >     pt_BR.po     x           o               o
> > 
> >   - (0), (1-1), (1-2) base on hg.pot older than 50f434510da6 (or
> >     2.3-rc) introducing "(DEPRECATED)"
> >   - (2) bases on hg.pot newer than 50f434510da6, but older than 3.6-rc
> >   - (3) bases on up-to-date hg.pot
> > 
> > (table above bases on *.po files at "3.6")
> > 
> > Looking up both "DEPRECATED" and "(DEPRECATED)" can avoid such
> > meaningless warning.
> 
> No, (1-2) should be warned because they have "... (DEPRECATED)" but lack
> "(DEPRECATED)". Try "LANG=da_DK.UTF-8 hg help serve" to see it fails to
> hide deprecated options.
> 
> I'll send the patches to fix this problem.

Oh, I forgot that help.py now requires existence of "(DEPRECATED)"
translation to hide them correctly. I focused only on
check-translation.py side :-<

Thanks for pointing out !

----------------------------------------------------------------------
[FUJIWARA Katsunori]                             foozy at lares.dti.ne.jp