[PATCH 3 of 3] rebase: introduce 'date' option

[Sean Farley]

Augie Fackler <raf at durin42.com> writes:

>> On Nov 5, 2015, at 5:39 PM, Ryan McElroy <rm at fb.com> wrote:
>> 
>> On 11/5/2015 6:40 AM, Augie Fackler wrote:
>>> On Tue, Nov 03, 2015 at 10:52:16AM -0800, Stanislau Hlebik wrote:
>>>> # HG changeset patch
>>>> # User Stanislau Hlebik <stash at fb.com>
>>>> # Date 1446576002 28800
>>>> #      Tue Nov 03 10:40:02 2015 -0800
>>>> # Node ID 57ed68cc2a33fb68d1e065e31202eccc3a2168b4
>>>> # Parent  93b187ce4d77839c3576db4d0ee626bbb8089382
>>>> rebase: introduce 'date' option
>>> I'm +0 on this, but wonder if it should also have a --current-date
>>> option, as it strikes me that's the most likely use case. Thoughts?
>> 
>> I like the idea of a "--current-date" flag (graft has this, right?), but I don't trust my ability to know what useful ways people will use UI, and "--date now”
>
> Huh, I didn’t know --date accepted “now”. Neat. Given that, I’m actually inclined to deprecate --current-date pretty much everywhere.

Same for me.

>> is pretty short (shorter, in fact, than "--current-date", so I'd be okay with just "--date". I'm also okay with dropping this since the first two are what we really needed to make tweakdefaults do the "--current-date" behavior at all times which was the real goal here. :-)
>> 
>> I'm curious as to what other people think about adding "--date" or "--current-date" or not adding it at all.
>
> Given the --date now option, I’m fine with this patch as stated as long as nobody else objects...

Again, same for me.