[PATCH STABLE] posix: insert seek between reads and writes on Solaris (issue4943)

Adrian Buehlmann adrian at cadifra.com
Sun Nov 15 17:34:38 CST 2015


On 2015-11-15 23:21, Gregory Szorc wrote:
> Yes, we copied a large block of source code. This is not ideal.
> However, posix.py and windows.py are very low level modules. There
> is no obvious existing module we could add the function to without
> introducing an import cycle. A new module will likely need to be
> invented. I'm not comfortable doing that on the stable branch.
> Once this patch is merged into @, we should clean up the duplicated
> code.

Perhaps you could move mixedfilemodewrapper to util.py and do the
wrapping there for the Solaris and Windows cases.

Likely not appropriate for stable indeed...



More information about the Mercurial-devel mailing list