[Bug 4962] New: hgweb: file comparison page can show wrong parent for removed file

mercurial-bugs at selenic.com mercurial-bugs at selenic.com
Mon Nov 23 04:23:11 UTC 2015


https://bz.mercurial-scm.org/show_bug.cgi?id=4962

            Bug ID: 4962
           Summary: hgweb: file comparison page can show wrong parent for
                    removed file
           Product: Mercurial
           Version: default branch
          Hardware: PC
                OS: Linux
            Status: UNCONFIRMED
          Severity: bug
          Priority: normal
         Component: hgweb
          Assignee: bugzilla at selenic.com
          Reporter: yuya at tcha.org
                CC: mercurial-devel at selenic.com

STR:

# prepare repository
hg init test
cd test
echo foo >> foo
hg ci -Am foo -u foo -d '0 0'
echo foo >> foo
hg ci -Am foo -u foo -d '0 0'
hg rm foo
hg ci -Am 'remove foo' -u foo -d '0 0'

hg log -q -T default foo --removed
2:346588efe7cb
1:47b3f5487abe
0:77d381135bdf

# start hgweb and access to
# http://localhost:8000/comparison/tip/foo
hg serve

It says "parents 77d381135bdf", but it should be "parents 47b3f5487abe".

This bug happens because the comparison falls back to ctx.parents()
if the file is removed at that revision.

https://selenic.com/repo/hg/file/3.6.1/mercurial/hgweb/webcommands.py#l844

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the Mercurial-devel mailing list