[PATCH 4 of 4 V2] histedit: add an experimental base action

Augie Fackler raf at durin42.com
Mon Nov 23 09:14:08 CST 2015


On Fri, Nov 20, 2015 at 12:59:23PM -0800, Durham Goode wrote:
>
>
> On 11/17/15 5:55 PM, Mateusz Kwapich wrote:
> ># HG changeset patch
> ># User Mateusz Kwapich <mitrandir at fb.com>
> ># Date 1447801471 28800
> >#      Tue Nov 17 15:04:31 2015 -0800
> ># Node ID 8a5d433817379070418e38e0a345d6e31a413188
> ># Parent  63635c88adcaa337e7f48bea12aed52a37e7891d
> >histedit: add an experimental base action
> >
> >This is a first (very simple) version of the histedit base action.
> >It works well in common usecases like rebasing the whole stack and
> >spliting the stack.
> >
> >I don't see any obvious edge cases - but probably there is more than one.
> >That's why I want to keep it behind experimental.histeditng config knob
> >for now. I think on knob for all new histedit behaviors is better because
> >we will test all of them together and testers will need to turn it on only
> >once to get all new nice things.
> >
> Aside from the comments in patch #1, I think the series looks good. I'm
> looking forward to shipping this to our git rebase -i enthusiasts.

Agreed. I fixed the one typo in flight, and I'm doing my own followup
(which I'll just push) to constant-ize the strings.

> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list