[PATCH v2] pager: migrate to core

[Bryan O'Sullivan]

On Tue, Nov 24, 2015 at 7:41 PM, Pierre-Yves David <
pierre-yves.david at ens-lyon.org> wrote:

>
> It's really not monkeypatching anything from my reading. Can you be more
>> specific about what you object to?
>>
>
> the current uisetup of pager is calling extensions.wrapfunction, I either
> miss your removal of it or it smell like monkey patching ;-)


That only happens if the color extension is used, so it doesn't count :-)
Not only that, but it even seems like a reasonable implementation given
that constraint.


> This is not what I meant here. I'm all for moving the code in core. I
> would like to be sure we do not have pager related regression before
> turning it one by default (if we do turn on by default at some point). And
> I'm at least aware of one such bug.
>

Can you please point me at it? I may be able to fix it, but a search of the
bug database for "pager" reveals nothing. Can't fix something without any
hint of its existence :-)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20151124/b1089987/attachment.html>