[PATCH STABLE] localrepo.commit: check all files for resolve state (issue4972)
Siddharth Agarwal
sid0 at fb.com
Mon Nov 30 18:33:23 CST 2015
# HG changeset patch
# User Siddharth Agarwal <sid0 at fb.com>
# Date 1448929888 28800
# Mon Nov 30 16:31:28 2015 -0800
# Branch stable
# Node ID 70219d705c72a9ae172a41d13a07535c0a5aa7ca
# Parent c3112b1b6a5b681ead90d8f627d580502b11336e
# Available At http://42.netv6.net/sid0-wip/hg/
# hg pull http://42.netv6.net/sid0-wip/hg/ -r 70219d705c72
localrepo.commit: check all files for resolve state (issue4972)
Previously we were only checking modified files for their resolve state. But a
file might be unresolved yet not in the modified state. Handle all such cases
properly.
diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py
--- a/mercurial/localrepo.py
+++ b/mercurial/localrepo.py
@@ -1556,19 +1556,12 @@ class localrepository(object):
if merge and cctx.deleted():
raise error.Abort(_("cannot commit merge with missing files"))
- unresolved, driverresolved = False, False
ms = mergemod.mergestate(self)
- for f in status.modified:
- if f in ms:
- if ms[f] == 'u':
- unresolved = True
- elif ms[f] == 'd':
- driverresolved = True
- if unresolved:
+ if list(ms.unresolved()):
raise error.Abort(_('unresolved merge conflicts '
'(see "hg help resolve")'))
- if driverresolved or ms.mdstate() != 's':
+ if ms.mdstate() != 's' or list(ms.driverresolved()):
raise error.Abort(_('driver-resolved merge conflicts'),
hint=_('run "hg resolve --all" to resolve'))
diff --git a/tests/test-commit-unresolved.t b/tests/test-commit-unresolved.t
--- a/tests/test-commit-unresolved.t
+++ b/tests/test-commit-unresolved.t
@@ -43,4 +43,25 @@ Mark the conflict as resolved and commit
(no more unresolved files)
$ hg commit -m "Merged"
+Test that if a file is removed but not marked resolved, the commit still fails
+(issue4972)
+
+ $ hg up .^
+ 1 files updated, 0 files merged, 1 files removed, 0 files unresolved
+ $ hg merge 2
+ merging A
+ warning: conflicts while merging A! (edit, then use 'hg resolve --mark')
+ 1 files updated, 0 files merged, 0 files removed, 1 files unresolved
+ use 'hg resolve' to retry unresolved file merges or 'hg update -C .' to abandon
+ [1]
+ $ hg rm --force A
+ $ hg commit -m merged
+ abort: unresolved merge conflicts (see "hg help resolve")
+ [255]
+
+ $ hg resolve -ma
+ (no more unresolved files)
+ $ hg commit -m merged
+ created new head
+
$ cd ..
More information about the Mercurial-devel
mailing list