[PATCH 4 of 4 V2] parsers: pure implementation of the new dirstate ordering

Sean Farley sean at farley.io
Tue Dec 1 02:20:04 UTC 2015


Sean Farley <sean at farley.io> writes:

> Laurent Charignon <lcharignon at fb.com> writes:
>
>> # HG changeset patch
>> # User Laurent Charignon <lcharignon at fb.com>
>> # Date 1448411881 28800
>> #      Tue Nov 24 16:38:01 2015 -0800
>> # Node ID f9959f2e4cd73d0bf06c6a325c4a33e4f5bd1a04
>> # Parent  749f9f5d6476c60ba9841415e4e94358fe3adf01
>> parsers: pure implementation of the new dirstate ordering
>>
>> This patch makes the pure implementation of pack_dirstate up to date with the
>> C implementation. It effectively writes the dirstate starting with the
>> non-normal files and ends with the normal files.
>
> Sorry if this was answered in the first version but are we now
> (unconditionally) going to write the dirstate in order? I assume because
> there would be some speedup (IIRC Durham had a patch assuming the order
> of the dirstate)?

Regardless of the answer to my question, I like the speed up of the
series. The C code looks fine to me and the slowdown is minor enough
that this passes my review.


More information about the Mercurial-devel mailing list