[PATCH 1 of 4] bookmarks: use recordchange instead of writing if transaction is active
Pierre-Yves David
pierre-yves.david at ens-lyon.org
Sun Oct 4 18:01:27 CDT 2015
On 10/04/2015 05:44 AM, FUJIWARA Katsunori wrote:
> # HG changeset patch
> # User FUJIWARA Katsunori <foozy at lares.dti.ne.jp>
> # Date 1443962009 -32400
> # Sun Oct 04 21:33:29 2015 +0900
> # Node ID 1655b19c19bdd94da85d568c1da65b09de4b402d
> # Parent 97dc6ab42aad232c73180dee648685c26662230b
> bookmarks: use recordchange instead of writing if transaction is active
I was initially not very enthousiastic about this patch because I would
like bookmark.write to just die and all bookmarks move to be done in the
transaction. And I would like code touching bookmark to have to
explicitly pass a transaction object so that they have to think about
the transaction life time when doing so.
However this seems like a step forward in all cases so I'll probably
take that patch anyway.
--
Pierre-Yves David
More information about the Mercurial-devel
mailing list