[PATCH 3 of 4] merge: get the default update destination from the function

Augie Fackler raf at durin42.com
Thu Oct 8 13:00:20 CDT 2015


> On Oct 8, 2015, at 13:45, Pierre-Yves David <pierre-yves.david at ens-lyon.org> wrote:
> 
> 
> 
> On 10/08/2015 10:33 AM, Augie Fackler wrote:
>> On Wed, Oct 07, 2015 at 12:02:23PM -0700, Pierre-Yves David wrote:
>>> # HG changeset patch
>>> # User Pierre-Yves David <pierre-yves.david at fb.com>
>>> # Date 1443503483 25200
>>> #      Mon Sep 28 22:11:23 2015 -0700
>>> # Node ID 224f781d36bdfa50e8db7a3e02d5398848a88b20
>>> # Parent  cb49c9ec614d20e21bc5affae1439a8abe727f5e
>>> merge: get the default update destination from the function
>>> 
>>> There is no value in using the revset instead of the extracted function.
>>> 
>> 
>> it seems there was: you just introduced an import cycle that you're
>> kludging around. Is it that important?
> 
> Is it important to stop using the revset? Yes, revset can't return other value like "bookmark to be updated".
> 
> To be honest I forgot about this cycle business, I can think of another location an break it in a follow up if you want to.

I look forward to the resend of this series that doesn't introduce the cycle. Dropping patches 2:: for now.

> 
> -- 
> Pierre-Yves David



More information about the Mercurial-devel mailing list