[PATCH] context: don't hex encode all unknown 20 char revision specs (issue4890)
Matt Mackall
mpm at selenic.com
Sun Oct 11 10:57:26 CDT 2015
On Fri, 2015-10-09 at 12:57 +0200, Mads Kiilerich wrote:
> >> - if len(changeid) == 20:
> >> + if len(changeid) == 20 and nonascii(changeid):
> >> changeid = hex(changeid)
> > You cannot put a regex check in the context creation fast path. That
> > code desperately needs to be faster, not slower.
> >
> > You are, however, welcome to make the error handler as slow as you want.
>
> This _is_ in the error handler.
Right, now it all makes sense. I thought this was the earlier "== 20"
block. Queued for default, thanks.
--
Mathematics is the supreme nostalgia of our time.
More information about the Mercurial-devel
mailing list