[PATCH 2 of 2] exchange: refactor bundle specification parsing

Gregory Szorc gregory.szorc at gmail.com
Mon Oct 12 22:11:15 CDT 2015


On Mon, Oct 12, 2015 at 5:54 PM, Pierre-Yves David <
pierre-yves.david at ens-lyon.org> wrote:

> --- a/mercurial/error.py
>> +++ b/mercurial/error.py
>> @@ -200,4 +200,7 @@ class CensoredBaseError(RevlogError):
>>       A delta based on a censored revision must be formed as single patch
>>       operation which replaces the entire base with new content. This
>> ensures
>>       the delta may be applied by clones which have not censored the base.
>>       """
>> +
>> +class UnsupportedBundleSpecification(Exception):
>> +    """error raised when a bundle specification is not supported."""
>>
>
> This probably want to inherite KeyError instead
> (just a very fast review, will give a proper review to this soon)


I disagree. KeyError is a low-level error from accessing something in a
dict-like that doesn't exist. This is a higher/application-level error.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20151012/693ace77/attachment.html>


More information about the Mercurial-devel mailing list