[PATCH 4 of 8] rebase: move no rebasestate file check out of restorestatus

Matt Mackall mpm at selenic.com
Fri Oct 16 17:43:11 CDT 2015


On Thu, 2015-10-15 at 19:33 -0700, Christian Delahousse wrote:
> # HG changeset patch
> # User Christian Delahousse <cdelahousse at fb.com>
> # Date 1444948508 25200
> #      Thu Oct 15 15:35:08 2015 -0700
> # Node ID ef6cee42f6058ae824978db8559920dd6c1e3fb2
> # Parent  d8c393e7c3bec8f2ba0ea286d121c05a999e7ade
> rebase: move no rebasestate file check out of restorestatus
> 
> Throwing exceptions when no statefile exists is not very exceptional.

Well.. it has the nice property that we always know what type to expect
when restorestatus returns. Here you've made it "nullable" without
updating all the callers to expect None. So now we'll get a weird tuple
unpacking traceback on one path. And you'll have to duplicate the
exception message.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list