[PATCH 4 of 5] shelve: use `shelf`

Matt Mackall mpm at selenic.com
Mon Oct 19 17:17:37 CDT 2015


On Thu, 2015-10-15 at 16:05 -0500, timeless at mozdev.org wrote:
> # HG changeset patch
> # User timeless at mozdev.org
> # Date 1444806915 14400
> #      Wed Oct 14 03:15:15 2015 -0400
> # Node ID cbe944c94864c2bdc303ed19e387de4b94c6383e
> # Parent  31bdbd8519204c15d79d92a8290bc2f48eba8914
> shelve: use `shelf`

It's actually not clear that this should be the name of the thing
created when shelving. When you shelve a book.. it doesn't become a
shelf, it's merely a shelved book. There are indeed a couple references
to "shelf" in the code:

$ hgrep shelf
hgext/shelve.py:    """subcommand that displays a single shelf"""
hgext/shelve.py:        raise error.Abort(_("--%s expects a single
shelf") % subcommand)
hgext/shelve.py:    shelfname = pats[0]
hgext/shelve.py:    if not shelvedfile(repo, shelfname,
'patch').exists():
hgext/shelve.py:        raise error.Abort(_("cannot find shelf %s") %
shelfname)

..but there are actually many more visible references to "shelved
changed", which is probably superior.

-- 
Mathematics is the supreme nostalgia of our time.



More information about the Mercurial-devel mailing list