[PATCH] histedit: add support for exec/x command to histedit (issue4036)

[Pierre-Yves David]

On 10/24/2015 05:13 PM, Piotr Listkiewicz wrote:
>     1) Check how the re-entrace is handled
>
>         2) Unlock the right amount of time
>         3) relock that amount of time
>         We probably want a context manager to handle that at the lock level.
>         Feel free to ask for more details if you need more guidance.
>         I really need guidance in this regard, i will be helpful for any
>         information about it,
>         because i even don't know how can i find case like this in
>         source code.
>
>
> Ok, reentrance is done in version V2
>
>     My point here is that if some command changed stuff (new commit,
>     bookmark location etc), some of it might not be detected by the
>     current process that already parsed them from disk and naively
>     assume they did not changed since it hold the lock.
>     I would like to see some investigation to know if we need to do
>     something special (or if it is already handled, for example by the
>     lock). to make sure we are safe here.
>
>
> We should talk about this, i still have no idea how can i check this or
> what to do with it

Sid, Foozy and yuya are good people discuss this.

-- 
Pierre-Yves David