[PATCH] histedit: add support for exec/x command to histedit (issue4036)

Piotr Listkiewicz piotr.listkiewicz at gmail.com
Wed Oct 28 03:17:22 CDT 2015


>
> Pretty good investigation, Thanks a lot. Can we get that added to the
> commit message?


Sure, added in Patch V4

2015-10-25 19:45 GMT+01:00 Pierre-Yves David <pierre-yves.david at ens-lyon.org
>:

>
>
> On 10/25/2015 04:33 PM, Piotr Listkiewicz wrote:
>
>>       My point here is that if some command changed stuff (new commit,
>>
>>              bookmark location etc), some of it might not be detected by
>> the
>>              current process that already parsed them from disk and
>> naively
>>              assume they did not changed since it hold the lock.
>>              I would like to see some investigation to know if we need to
>> do
>>              something special (or if it is already handled, for example
>>         by the
>>              lock). to make sure we are safe here.
>>
>>         We should talk about this, i still have no idea how can i check
>>         this or
>>         what to do with it
>>         Sid, Foozy and yuya are good people discuss this
>>
>>
>>  From my investigation and talk with yuya i think that all caches are
>> cleared:
>>
>> finally:
>>      self.state.wlock = repo.wlock(times=wlockheld)
>>      self.state.lock   = repo.lock(times=lockheld)
>>
>> repo.wlock invoke lock constructor with acquirefn callback set to
>> localrepo.invalidatedirstate.
>>
>> repo.lock invoke lock constructor with acquirefn callback set to
>> localrepo.invalidate.
>>
>> invalidateall function in localrepository has invocation only to
>> invalidate and invalidatedirstate.
>>
>> So if acquiring those two locks dont clear all caches that would mean
>> that localrepository.invalidateall has bug right now.
>>
>
> Pretty good investigation, Thanks a lot. Can we get that added to the
> commit message?
>
> --
> Pierre-Yves David
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://selenic.com/pipermail/mercurial-devel/attachments/20151028/d9f4e802/attachment.html>


More information about the Mercurial-devel mailing list