[PATCH v2] histedit: use one editor when multiple folds happen in a row (issue3524) (BC)

Durham Goode durham at fb.com
Tue Sep 1 17:16:45 CDT 2015



On 9/1/15, 12:59 PM, "Augie Fackler" <raf at durin42.com> wrote:

>On Tue, Sep 1, 2015 at 1:23 PM, Durham Goode <durham at fb.com> wrote:
>> I agree, it's a little beyond what we need, but given histedit's
>>history, I
>> think it'd be worth doing.
>>
>> It might also enable other interesting things from extensions.  For
>> instance, if we wanted to remove the need to specify 'drop' lines, we
>>could
>> have the drop action class preprocess the list to add 'drop' entries
>>when
>> the user has deleted lines.  Or if we wanted to add a 'review' action,
>>the
>> action could be implemented as a preprocessor that replaces 'review'
>>actions
>> with 'exec run_my_review_tool'
>
>So, I've started working on this, and I'm of the opinion that it's
>something we should do later. Reason being, it's underspecified:
>
>How do I know what order to run the preprocessors in? How do I know
>that my preprocessor is going to run late enough in the stack to do
>what I want? Or early enough?
>
>I think we should wait until there's a concrete second user to
>actually do this refactor. Note that I'm *fine* with that second user
>being out of tree, I just can't quite figure out what the Right API is
>going to be today because my crystal ball is still broken.

Fair enough. I'm fine doing it later then.  As long as we keep a close eye
on the hardcoding creep.



More information about the Mercurial-devel mailing list