[PATCH 4 of 5] templater: port localdate filter to a function

Yuya Nishihara yuya at tcha.org
Wed Sep 2 09:43:41 CDT 2015


On Tue, 1 Sep 2015 11:15:11 -0400, timeless wrote:
> > +        raise error.ParseError(_("localdate expects a date information"))
> 
> This should be word-smithed.
> 
> "a date" (it's singular), works; "date information" works (information is
> more or less plural here, and date is an adjective); "a date information"
> doesn't work (mixing singular and plural)
> 
> You could add "object" to the end, or replace the word information with it;
> you could possibly omit "a".

Oops. I can just say "a date" here because the localdate function accepts
both (time, offset) tuple and a date text.

Is there a better term for (time, offset) tuple? Currently it is called as
"date information", but it seems unclear to me.


More information about the Mercurial-devel mailing list