[PATCH] exchange: allow fallbackheads to use lazy set behavior

[Augie Fackler]

On Mon, Sep 07, 2015 at 05:13:09PM -0700, Durham Goode wrote:
> # HG changeset patch
> # User Durham Goode <durham at fb.com>
> # Date 1441670915 25200
> #      Mon Sep 07 17:08:35 2015 -0700
> # Node ID c595696df8614f58194e210f8b3b1d4c1a25926e
> # Parent  d72ff051c6c6dee945690b0e5554a0450820e93e
> exchange: allow fallbackheads to use lazy set behavior

Queued, awesome.

>
> The common ancestor set implementation was made lazy a couple years ago, but
> this piece of code still required processing the entire repo by putting set()
> around the lazy set. The code was introduced in 5653f2d166ea, a year before the
> lazy ancestor set was added.
>
> Dropping the set() shaves 3.5 seconds off of 'push -r' in repos with hundreds of
> thousands of commits.
>
> diff --git a/mercurial/exchange.py b/mercurial/exchange.py
> --- a/mercurial/exchange.py
> +++ b/mercurial/exchange.py
> @@ -147,7 +147,7 @@ class pushoperation(object):
>          #
>          # We can pick:
>          # * missingheads part of common (::commonheads)
> -        common = set(self.outgoing.common)
> +        common = self.outgoing.common
>          nm = self.repo.changelog.nodemap
>          cheads = [node for node in self.revs if nm[node] in common]
>          # and
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at selenic.com
> https://selenic.com/mailman/listinfo/mercurial-devel